Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Arrange Modal 생성 #90

Merged
merged 3 commits into from
Jul 10, 2024
Merged

[FEAT] Arrange Modal 생성 #90

merged 3 commits into from
Jul 10, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Jul 10, 2024

작업 내용 🧑‍💻

  • Today 페이지의 Staging Area에서의 정렬 기능을 수행할 Arrange Modal을 퍼블리싱 하였습니다.
    • activeSorByDateAdded(최신 등록순, 오래된 등록순) / activeSorByDeadLine(가까운 마감기한순, 먼 마감기한순) 로 크게 구분 가능합니다. 각 세트별로 정렬 선택 가능한 부분이라 상태를 2개로 나눴습니다!

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • Staging Area(:쏟아내기)에서 SortBtn 클릭 시 사용될 모달입니다!
  • activeSorByDateAdded(최신 등록순, 오래된 등록순) / activeSorByDeadLine(가까운 마감기한순, 먼 마감기한순) 은 각 세트별로 정렬 선택 가능한 부분이라 상태를 2개로 나눴습니다!

관련 이슈

close #86

스크린샷 (선택)

Jul-11-2024 02-46-02

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 동작하고 너무 좋으네용! 밑에 남긴 것처럼 상수로 처리하는 건 어떠실지 의견 궁금합니당 👍

<ModalArrangeLayout>
<SortBy>
<SortBtn
text="최신 등록순"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 최신 등록순, 오래된 등록순 등을 상수로 빼서 관리하는 건 어떨까요? 의견 궁금합니당!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 네엡 조아요

Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 만든 버튼이라 헷갈리셨을 수도 있는데,, (피알도 레전드 불친절) 잘 묶어서 사용해주셨네요!! 수고하셨습니다 ㅎㅎ

@Kjiw0n Kjiw0n merged commit 7d1dd0f into develop Jul 10, 2024
2 checks passed
@Kjiw0n Kjiw0n deleted the feat/#86-arrange-modal branch July 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Arrange Modal 생성
3 participants